Implement NMT multiproof verification. #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
commented
Jan 3, 2023
| @@ -1,2 +1,3 @@ | |||
| [profile.default] | |||
| solc_version = "0.8.11" | |||
| via_ir = true | |||
There was a problem hiding this comment.
This is needed to avoid stack too deep error. Will result in longer compile times but that should be fine since the contracts are small anyways. The QGB contract doesn't have to be re-compiled / bindings re-generated (ABI is identical).
rach-id
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
Dope 🚀
Thanks a lot for your help.
Question:
Now that we have the implementation of the multiproof, does it make sense to create a separate contract that calls it? And we generate a go wrapper for this latter so that we use it in the verification command we're planning to have for the QGB?
If so, I can create an issue and start working on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128
Implements https://github.com/celestiaorg/nmt/blob/95e8313eb788b46b30f3f85b20fd9a40bf68d432/proof.go#L140.