Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: add inclusion proofs documentation #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add inclusion proofs documentation #160
Changes from 21 commits
583d0ba
d18e7f1
98146f9
db8cebc
0bb7331
deb892d
9613782
4cd1b15
143a8ed
a1f1f93
a744e5f
a162e36
1532c35
d8afca4
318f355
7087ccf
2376626
28ffbdd
cdcdf90
4fcd55e
4c0a688
28b05c1
feeba92
40ac2b4
eafab55
079a7a2
b60d942
a2c7e43
eaca8b1
ea4ae1f
820280c
5e615eb
68b1a02
0a32cf9
630e9d8
e059edc
1caee0c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there types of celestiums that aren't smart contract based?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess they all are smart contract based, but light clients also can verify the proofs before the settlement smart contract executes them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a span?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like this: https://github.com/celestiaorg/quantum-gravity-bridge/blob/28ffbdd1f20798b410ee2d3a213e70df8edfebd3/src/lib/verifier/test/RollupFraudProof.t.sol#L22-L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sequence of data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like this: https://github.com/celestiaorg/quantum-gravity-bridge/blob/28ffbdd1f20798b410ee2d3a213e70df8edfebd3/src/lib/verifier/test/RollupFraudProof.t.sol#L22-L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what occurs when the celestium needs to prove inclusion to multiple chunks of data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That depends on how they want to separate their data. Generally, they would have multiple references to data in Celestia blocks and they would prove inclusion to one of them