Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump solidity version to v0.8.21 #221

Merged
merged 5 commits into from
Oct 15, 2023

Conversation

rach-id
Copy link
Member

@rach-id rach-id commented Oct 6, 2023

Overview

When verifying the QGB contract, these were signaled by Etherscan:
https://sepolia.etherscan.io/solcbuginfo?a=FullInlinerNonExpressionSplitArgumentEvaluationOrder
https://sepolia.etherscan.io/solcbuginfo?a=MissingSideEffectsOnSelectorAccess

Which are fixed with this version bump.

Also closes: #136

Checklist

  • New and updated code has appropriate documentation
  • New and updated code has new and/or updated testing
  • Required CI checks are passing
  • Visual proof for any user facing features like CLI or documentation updates
  • Linked issues closed with keywords

@rach-id rach-id added T:Dependencies Pull requests that update a dependency file contracts labels Oct 6, 2023
@rach-id rach-id requested a review from evan-forbes October 6, 2023 09:38
@rach-id rach-id self-assigned this Oct 6, 2023
@rach-id rach-id requested a review from adlerjohn as a code owner October 6, 2023 09:38
@rach-id rach-id enabled auto-merge (squash) October 13, 2023 09:50
@rach-id rach-id requested a review from adlerjohn October 13, 2023 09:50
@rach-id rach-id merged commit 3dc8592 into celestiaorg:master Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts T:Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QGB smart contract code verification
3 participants