-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add slither static analyzer #225
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of a separate file that also requires downloading foundry etc. why not just fold this into the primary ci workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary CI workflow is building also the test files (for tests) and the libraries and all. If we run slither on that it gives +200 vulnerability related to our tests and the libraries we're using.
However, in this separate workflow, it is only building the src contracts and no test files and running the code analysis only against them. So we don't have to go through 200 vulnerability and trying to find ones related to our source code.
If we want to use the primary CI workflow, that would mean we would need to delete the built files then rebuild the project different and that gets messy. I think this way is cleaner
Overview
Checklist