-
Notifications
You must be signed in to change notification settings - Fork 250
Add package to provide gevent compatibiliy (#628) #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks @aberres! Having this in the core library README is a bit weird (as one can imagine, eventually we'll end up with workarounds for all kinds of 3rd party stuff in the main README, which could confuse/scare the audiences), probably having an extension What's in my mind:
|
@reyang fair enough. I just pushed a commit containing a new package which makes things "just work" when it is installed. I did not polish this yet, I want to check first of this is more to your liking. |
contrib/opencensus-ext-gevent/opencensus/ext/gevent/geventcompatibility.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, I've left some minor suggestions.
This approach is amazing!
This is great, thanks for the contribution @aberres! |
contrib/opencensus-ext-gevent/opencensus/ext/gevent/geventcompatibility.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @reyang said, we need a test that the patch works as expected before we can merge this. It would also be useful to check the entry point, i.e. load the patched gevent first.
contrib/opencensus-ext-gevent/opencensus/ext/gevent/geventcompatibility.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will merge once CI is clean.
|
||
logging.warning("OpenCensus patched for gevent compatibility") | ||
else: | ||
logging.warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Thanks @aberres for the great work! |
How long until this package hits pypi? |
@allenjohnashton sorry for the delay, here you go https://pypi.org/project/opencensus-ext-gevent/. In general we try to have at least a release per month. |
Thanks! |
No description provided.