Skip to content

Fix issues in CI pipeline #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 22 commits into from
Closed

Conversation

phelps-sg
Copy link
Contributor

@phelps-sg phelps-sg commented Jun 18, 2023

This PR resolves outstanding issues with the CI pipeline. This includes both issues with the CI configuration itself (fixes #29, fixes #34, fixes #35) , and also build problems encountered with Scala 3 (fixes #36, fixes #37, fixes #38).

@phelps-sg phelps-sg changed the title Apply scalafmt to all source files to test CI pipeline Fix issues in CI pipeline Jun 18, 2023
@phelps-sg
Copy link
Contributor Author

I believe the CI pipeline is now working correctly, but there seems to be a legitimate problem compiling for Scala 3.2.2- see #38. Fixes # 34, fixes #35, fixes #36 and fixes #37.

@phelps-sg
Copy link
Contributor Author

Fixes #38

@peterbanda
Copy link
Member

Due to configuring and running Scalafix and Scalafmt on the entire code base there are too many conflicts to resolve. Could you perhaps extract only the relevant parts - i.e. changes in build.sbtand continuous-integration.yml? I can do it as well.

peterbanda added a commit that referenced this pull request Jul 18, 2023
@peterbanda
Copy link
Member

All the relevant parts are now in the master branch. Thanks @phelps-sg !

@peterbanda peterbanda closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment