Skip to content

Add manual testing instructions #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2018
Merged

Conversation

jimmynotjim
Copy link
Contributor

Add manual testing instructions to the browser support guide to help ensure developers are adhering to our list of supported browsers.

Additions

  • Added instructions for localtunnel
  • Added section for Saucelabs, needs content from @cfarm

Testing

  1. Follow the instructions to set up localtunnel on your machine.

Todos

  • Add Saucelabs instructions.

Checklist

@marteki
Copy link

marteki commented Jun 25, 2018

The localtunnel instructions worked this morning from me to set up, run, and use for a PR review. 👍

@@ -114,6 +114,33 @@ browsers:
- iOS Safari
- Chrome for Android

#### Manual testing

We use a mix of Saucelabs and [localtunnel](https://localtunnel.github.io/www/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically Sauce Labs.


We use a mix of Saucelabs and [localtunnel](https://localtunnel.github.io/www/)
to manually test our site. Be sure to review both the testing and accessibility
guides when reviewing sites locally.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be links to the guides here or a blurb on where to find them? I feel like someone joining the project could read this and be like "where do I find those?"


##### Saucelabs

_Need Cat's demo instructions._
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe don't include this section till Cat's demo instructions are in.

Start your project's localhost and in a separate tab run `lt --port 8000`
editing the port value to match your localhost setup. This will create a
temporary public URL that can be accessed from any device on any connection.
Navigate to the URL from your device and test to your hearts content, the URL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heart's content

temporary public URL that can be accessed from any device on any connection.
Navigate to the URL from your device and test to your hearts content, the URL
will remain active as long as the instance is active (keep this in mind, don't
leave it running forever).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add to close it with ctrl + c.

@jimmynotjim jimmynotjim force-pushed the localtunnel-instructions branch from 0fd6a56 to ea08883 Compare June 29, 2018 21:37

##### Sauce Labs

See [#171](https://github.com/cfpb/development/pull/171) for details on testing
Copy link
Member

@anselmbradford anselmbradford Jul 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to the Pull Request and not the document that 171 added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR isn't merged yet :( When it is, I'll update to point to that doc

@jimmynotjim
Copy link
Contributor Author

It's been more than a week, merging as is and we can update if/when #171 is merged.

@jimmynotjim jimmynotjim merged commit 34087ad into master Jul 2, 2018
@jimmynotjim jimmynotjim deleted the localtunnel-instructions branch July 2, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants