Allow SAFE_RUN to correctly run and check results

[koalaman]

Hi, I came across this shell function in test/native-tests/test_native.sh:

SAFE_RUN() {
    local SF_RETURN_VALUE=$($1 2>&1)

    if [[ $? != 0 ]]; then
        >&2 echo $SF_RETURN_VALUE
        exit 1
    fi
}

invoked as e.g.

SAFE_RUN `cd $TEST_PATH; ${CH_DIR} Platform.js > Makefile`

There are multiple issues that prevent it from living up to its name:

1. The code to run is executed by the backticks before the function ever starts:

$ test_run() { true; }
$ test_run `ls /doesnotexist`
ls: cannot access '/doesnotexist': No such file or directory

2. If the invocation is changed to pass the command directly, the invocation fails for metacharacters like ; and >. Here they are both treated as literal text:

$ test_run() { local var=$($1 >&2); echo "$var"; }
$ test_run "echo Hello; ls > filelist"
Hello; ls > filelist

3. If passed a valid invocation, local masks all exit codes and returns success, even when the command fails:

$ test_run() { local foo=$($1); echo  "$1 returned $?"; }
$ test_run true
true returned 0
$ test_run false
false returned 0

The suggested commits fixes all these issues.

I was unable to verify the fix locally as the tests appeared to hang when run overnight with and without these fixes. I'm not quite sure how they're used, but there is some possibility that this commit uncovers failures that were previously hidden.

[atulkatti]

@koalaman Changes look good to me. This script is used to run tests in our cross platform test runs. I will start the process to rebase and validate this again. If everything goes as expected the change will get pushed to GitHub through our internal tooling. Thanks for working on this. Much appreciated.

[atulkatti]

@koalaman Can you please rebase and push your branch again?

[koalaman]

@atulkatti Done