-
Notifications
You must be signed in to change notification settings - Fork 139
Conversation
🦋 Changeset detectedLatest commit: 3d2ab89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). chakra-ui-vue – ./🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/BhNu4Y6ohXd5tCWVFjLE1Q1R1cCn |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d2ab89:
|
emitChange(value, $e) | ||
if (typeof emitChange === 'function') { | ||
return emitChange(value, $e) | ||
} | ||
emitChange.forEach(listener => listener(value, $e)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change @peoray. Do you think we can add a test case for this change?
One more thing I found missing this PR is that See reproduction here: |
Description
When using the event
@change
in<CTextarea v-if="isTextArea" placeholder="Insert your text" v-model="text" @change="handleText" />
, it displays an error that it is not a function.This PR fixes the error and allows the change event to be used on the
CTextarea
component and adds a story with the change event.Motivation and Context
Fixes #356
Types of changes
Checklist: