Skip to content

Update Sliding Window Maximum.cpp #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Sliding Window Maximum.cpp #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions problem/Heap/Sliding Window Maximum.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@ O(nlogn) time, O(n) space
typedef pair<int, int> Pair;

void MaxSlidingWindow2(int arr[], int len, int k, int window[]) {
priority_queue<Pair> Q;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use q and Q in different places, need stick to one , q or Q

for (int i = 0; i < k; ++i) {
priority_queue<Pair> q;
for (int i = 0; i < k; ++j) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable j is not defined here

Q.push(Pair(arr[i], i));
}

for (int i = k; i < len; ++i) {

Pair p = Q.top();
//hhhhh
Pair p = q.top();
window[i-k] = p.first;
while (p.second <= i-k) {//pop the old elements not in new window

Expand All @@ -65,7 +67,7 @@ void MaxSlidingWindow3(int arr[], int len, int k, int window[]) {
for (int i = 0; i < k; ++i) {

while (!Q.empty() && arr[i] >= arr[Q.back()]) { //elements in the deque decreases.
Q.pop_back();
q.pop_back();
}

Q.push_back(i);
Expand All @@ -80,7 +82,7 @@ void MaxSlidingWindow3(int arr[], int len, int k, int window[]) {
}

while (!Q.empty() && Q.front() <= i-k) {//pop the old elements not in new window
Q.pop_front();
q.pop_front();
}

Q.push_back(i);
Expand Down