-
-
Notifications
You must be signed in to change notification settings - Fork 2
Preview to main #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Preview to main #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
chrisweb
commented
Feb 19, 2025
- shiki 3.0.0 has a breaking change in rehype pretty code, so I stayed on 2.5.0 (Shiki 3 rehype-pretty/rehype-pretty-code#257)
- eslint-import-resolver-typescript 3.8.2 has a new glob dependency that breaks import aliases so I stayed on 3.7.0 (Unable to resolve path to module with aliases. import-js/eslint-import-resolver-typescript#359)
- sentry > 9 supports excluding components when using the annotations feature, however I tried several component names to exclude react three fiber and none seemed to work, so I kept the next.config.ts option disabled (feat(react-component-annotate): Allow skipping annotations on specified components getsentry/sentry-javascript-bundler-plugins#617)
- r3f and related packages are still RC versions as those have support for React 19
- React 19 and Next.js are set to canary to be able to experiment with new features (and because this is my personal blog)
…ree fiber has problems with the annotations attributes sentry adds
…f variants but none works
…t-import-resolver-typescript 3.8.0 breaks import aliases
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (4)
- app/global.css: Language not supported
- app/web_development/posts/sentry-io/page.mdx: Language not supported
- app/web_development/tutorials/next-js-static-first-mdx-starterkit/error-handling-and-logging/page.mdx: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (3)
components/neonRoad/Canvas.tsx:1
- The message should be 'Sorry, this 3D animation cannot be displayed on your device' instead of 'can not'.
Fallback = () => { return (<>Sorry, this 3D animation can not be displayed on your device</>) }
next.config.ts:445
- The
sourcemaps
configuration is commented out and might be incomplete. Ensure that it is correctly configured or remove the commented-out lines.
sourcemaps: {
app/global-error.tsx:25
- Changing the header from
to
changes the semantic meaning of the header, which could impact accessibility and SEO.
<h1 className="h3">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.