Skip to content

Commit 8ded144

Browse files
committed
Updated jQuery from 1.8.2 to 3.4.1 to address the prototype pollution issue (cucumber#1791)
1 parent c146380 commit 8ded144

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

core/src/main/java/io/cucumber/core/plugin/HTMLFormatter.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ public final class HTMLFormatter implements EventListener {
5858
private static final String[] TEXT_ASSETS = new String[]{
5959
"/io/cucumber/core/plugin/html/formatter.js",
6060
"/io/cucumber/core/plugin/html/index.html",
61-
"/io/cucumber/core/plugin/html/jquery-1.8.2.min.js",
61+
"/io/cucumber/core/plugin/html/jquery-3.4.1.min.js",
6262
"/io/cucumber/core/plugin/html/style.css"
6363
};
6464
private static final Map<String, String> MIME_TYPES_EXTENSIONS = new HashMap<String, String>() {

core/src/main/resources/io/cucumber/core/plugin/html/formatter.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ CucumberHTML.DOMFormatter = function(rootNode) {
8686
if (isLastStep) {
8787
if (currentSteps.find('.failed').length == 0) {
8888
// No failed steps. Collapse it.
89-
currentElement.find('details').removeAttr('open');
89+
currentElement.find('details').prop('open', false);
9090
} else {
9191
currentElement.find('details').attr('open', 'open');
9292
}

core/src/main/resources/io/cucumber/core/plugin/html/index.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<meta charset="utf-8">
55
<title>Cucumber Features</title>
66
<link href="style.css" rel="stylesheet">
7-
<script src="jquery-1.8.2.min.js"></script>
7+
<script src="jquery-3.4.1.min.js"></script>
88
<script src="formatter.js"></script>
99
<script src="report.js"></script>
1010
</head>

core/src/main/resources/io/cucumber/core/plugin/html/jquery-1.8.2.min.js

-2
This file was deleted.

core/src/main/resources/io/cucumber/core/plugin/html/jquery-3.4.1.min.js

+2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)