Skip to content

Cucumber 4.7.3 Uses jquery 1.8.2 with a security vunerability #1791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
foxy82 opened this issue Oct 7, 2019 · 3 comments
Closed

Cucumber 4.7.3 Uses jquery 1.8.2 with a security vunerability #1791

foxy82 opened this issue Oct 7, 2019 · 3 comments
Labels
🐛 bug Defect / Bug

Comments

@foxy82
Copy link

foxy82 commented Oct 7, 2019

Describe the bug
Thanks for fixing: #1786

However the HTML formatter still uses jquery 1.8.2 which again has a high impact security vulnerability.

cucumber-jvm/core/src/main/java/cucumber/runtime/formatter/HTMLFormatter.java

Line 59 in 8e7957f

"/io/cucumber/formatter/html/jquery-1.8.2.min.js",

Can this one also be updated?

Thanks
@foxy82 foxy82 added the 🐛 bug Defect / Bug label Oct 7, 2019
@aslakhellesoy
Copy link
Contributor

Can you please send a pull request with a fix @foxy82?

Many thanks

clarkead added a commit to clarkead/cucumber-jvm that referenced this issue Oct 8, 2019
@clarkead
Updated jQuery from 1.8.2 to 3.4.1 to address the prototype pollution…
8ded144 
… issue (cucumber#1791)
@clarkead
Copy link
Contributor

clarkead commented Oct 8, 2019 •
edited
Loading

PR Submitted

@mpkorstanje
Copy link
Contributor

Fixed by #1794

@timtebeek timtebeek mentioned this issue May 12, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Defect / Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@aslakhellesoy @mpkorstanje @foxy82 @clarkead