-
Notifications
You must be signed in to change notification settings - Fork 696
Normalise document titles #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexisintech
approved these changes
Aug 16, 2024
octoper
pushed a commit
that referenced
this pull request
Aug 22, 2024
Co-authored-by: Alexis Aguilar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
🚨 https://github.com/clerk/clerk/pull/568 must be merged before this PR.✅This PR removes h1 elements from content, in favour of the
title
frontmatter field. See discussion for more info.The transform was applied according to the following rules:
title
, skip ittitle
title
:title
with the h1, and remove the h1The following files contain both a h1 and a✅title
but a resolution is not obvious to me. @alexisintech would you mind taking a look at these and settling on a singletitle
for each?Files
docs/authentication/overview.mdx
docs/deployments/exporting-users.mdx
docs/guides/basic-rbac.mdx
docs/guides/overview.mdx
docs/guides/transferring-your-app.mdx
docs/organizations/overview.mdx
docs/upgrade-guides/overview.mdx
docs/backend-requests/versioning/overview.mdx
docs/components/customization/layout.mdx
docs/components/customization/organization-profile.mdx
docs/authentication/social-connections/x-twitter.mdx
docs/integrations/databases/neon.mdx
docs/integrations/webhooks/loops.mdx
docs/references/astro/clerk-middleware.mdx
docs/references/nextjs/auth-middleware.mdx
docs/references/nextjs/clerk-middleware.mdx
docs/references/nextjs/overview.mdx
docs/references/ruby/available-methods.mdx
docs/references/ruby/rack-rails.mdx
docs/upgrade-guides/core-2/backend.mdx
docs/upgrade-guides/core-2/chrome-extension.mdx
docs/upgrade-guides/core-2/expo.mdx
docs/upgrade-guides/core-2/fastify.mdx
docs/upgrade-guides/core-2/javascript.mdx
docs/upgrade-guides/core-2/nextjs.mdx
docs/upgrade-guides/core-2/node.mdx
docs/upgrade-guides/core-2/react.mdx
docs/upgrade-guides/core-2/remix.mdx
docs/references/javascript/user/totp.mdx