Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(react quickstart) small copy updates; fix code highlight #2094

Merged
merged 2 commits into from
Apr 1, 2025

Conversation

Akul-sada
Copy link

Fix some grammar
Change the code highlighter

🔎 Previews:

What does this solve?

What changed?

Checklist

  • I have clicked on "Files changed" and performed a thorough self-review
  • I have added the "deploy-preview" label and added the preview link(s) to this PR description
  • All existing checks pass

Fix some grammar
Change the code highlighter
@Akul-sada Akul-sada requested a review from a team as a code owner March 11, 2025 15:25
Copy link
Member

@alexisintech alexisintech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice updates! I've left a few comments for you to address before I can approve 🙏

@@ -98,7 +98,7 @@ VITE_CLERK_PUBLISHABLE_KEY={{pub_key}}

### Import the Clerk publishable key

You will need to import your Clerk publishable key into your application. You can add an `if` statement to check that it is imported and that it exists. This will prevent running the application without the publishable key, and will also prevent TypeScript errors.
You will need to import your Clerk publishable key into your application. You can add an `if` statement to check that it is imported and that it exists. This will prevent running the application without the publishable key and prevent TypeScript errors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You will need to import your Clerk publishable key into your application. You can add an `if` statement to check that it is imported and that it exists. This will prevent running the application without the publishable key and prevent TypeScript errors.
You will need to import your Clerk publishable key into your application. You can add an `if` statement to check that it is imported and that it exists. This will prevent running the application without the Publishable Key and prevent TypeScript errors.

Comment on lines 192 to 196
<Cards title="Prebuilt Components" description=" Learn more about Clerk's suite of components that let you quickly add authentication to your app." link="/docs/components/overview" cta=" Learn More" />

<Cards title="Customization & Localization" description="Learn how to customize and localize Clerk components." link="/docs/components/customization/overview" cta="Learn More" />
<Cards title="Customization & Localization" description=" Learn how to customize and localize Clerk components." link="/docs/components/customization/overview" cta=" Learn More" />

<Cards title="Client Side Helpers" description="Learn more about our client side helpers and how to use them." link="/docs/references/react/use-user" cta="Learn More" />
<Cards title="Client Side Helpers" description=" Learn more about our client side helpers and how to use them." link="/docs/references/react/use-user" cta= "Learn More" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't agree with the spacing updates here

@alexisintech alexisintech changed the title Updated react.mdx (react quickstart) small copy updates; fix code highlight Apr 1, 2025
@alexisintech alexisintech merged commit c2541b9 into clerk:core-1 Apr 1, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants