-
Notifications
You must be signed in to change notification settings - Fork 696
Rename redirect and fallback url props #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename redirect and fallback url props #943
Conversation
Hey, here’s your docs preview: https://clerk.com/docs/pr/943 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch on . also needs updates. The props are
<SignUpButton signInFallbackRedirectUrl="" signInForceRedirectUrl="" fallbackRedirectUrl="" forceRedirectUrl="" />
For looks like we dropped the signOutCallback
and instead added redirectUrl
. Please also see https://clerkinc.slack.com/archives/C04KENP2GFL/p1713966411590549?thread_ts=1713901849.337169&cid=C04KENP2GFL in relation to SignOutButton as it can be passed as an option. I'm asking for clarification if that's initial.
Currently the props are:
redirectUrl
signOutOptionss
children
The SignOutOptionss is an object that looks like:
export type SignOutOptions = {
/**
* Specify a specific session to sign out. Useful for
* multi-session applications.
*/
sessionId?: string;
/**
* Specify a redirect URL to navigate after sign out is complete.
*/
redirectUrl?: string;
};
I believe that this has not been clarified? At the minimum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, some minor comments regarding the order of the props
Addressed feedback, got other approvals
A customer reported an issue with props like
signInFallbackRedirectUrl
- thread hereChanges in this PR:
SignUp
-related components, we should listsignInFallbackRedirectUrl
andfallbackRedirectUrl
rather than listingsignUpFallbackRedirectUrl
.SignIn
-related components.Previews: