Skip to content

Remove Cypress from docs for now #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Remove Cypress from docs for now #954

merged 2 commits into from
Apr 26, 2024

Conversation

alexisintech
Copy link
Member

@alexisintech alexisintech commented Apr 26, 2024

Was previously removed in this PR: #905
More details in that description.

The recent relevant slack discussion: https://clerkinc.slack.com/archives/C01QFRQNHSN/p1714079624844859

@alexisintech alexisintech requested a review from a team as a code owner April 26, 2024 16:06
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/954

Copy link
Contributor

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but can't they still access it via links (and won't it still be indexed in Google)?

@S3Prototype
Copy link
Contributor

Actually it might also still be indexed in our search

@alexisintech
Copy link
Member Author

Approved but can't they still access it via links (and won't it still be indexed in Google)?

ummm I'm not sure why it didn't add my commits of removing the file entirely.. that's weird

@alexisintech
Copy link
Member Author

ahh I see, when I rebased to main, it readded the files. I just removed them. merging now!

@alexisintech alexisintech merged commit ec0b0a2 into main Apr 26, 2024
1 check passed
@alexisintech alexisintech deleted the aa/DOCS-6051 branch April 26, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants