fix(repo): Always load local clerk-js when running integration tests #2025
Conversation
|
| - name: Run Integration Tests | ||
| run: npm run test:integration:${{ matrix.test-name }} | ||
| run: E2E_APP_CLERK_JS_DIR=$RUNNER_TEMP npm run test:integration:${{ matrix.test-name }} |
There was a problem hiding this comment.
Nit: Define the env var in the env section below that script
There was a problem hiding this comment.
Opening a second PR, thanks @LekoArts that's cleaner
| @@ -63,9 +61,10 @@ export const application = (config: ApplicationConfig, appDirPath: string, appDi | |||
| stderr: opts.detached ? fs.openSync(stderrFilePath, 'a') : undefined, | |||
| log: opts.detached ? undefined : log, | |||
| }); | |||
| // const shouldRetry = () => proc.exitCode !== 0 && proc.exitCode !== null; | |||
There was a problem hiding this comment.
This should've been a todo - changing it in the new PR
dimkl
changed the title
Description
http-serveras a deptreekillto correctly await itChecklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore