feat(dev-cli): Remove macOS-specific Terminal functionality #3859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d432332 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brkalow
approved these changes
Aug 1, 2024
Comment on lines
-53
to
-56
| spawn('osascript', [ | ||
| '-e', | ||
| `tell app "Terminal" to do script "cd ${cwd} && turbo run dev --filter=@clerk/clerk-js -- --env devOrigin=http://localhost:4000"`, | ||
| ]); |
LekoArts
approved these changes
Aug 1, 2024
nikosdouvlis
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the macOS-specific functionality that was used to spawn a new Terminal window containing the builder for
clerk-jsin favor of simply usingconcurrentlyto run everything in the same terminal instance. To make it easier to distinguish the output, we use concurrently'sprefixColorsfeature which prepends[packages]for the build process of dependencies and[clerk-js]for theclerk-jsbuild.Checklist
npm testruns as expected.npm run buildruns as expected.Type of change