fix(nextjs): Avoid calling safeParseClerkFile before checking if keyless is allowed
#4981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yless is allowed
🦋 Changeset detectedLatest commit: c528e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
anagstef
approved these changes
Jan 23, 2025
tmilewski
approved these changes
Jan 23, 2025
jacekradko
reviewed
Jan 23, 2025
Comment on lines
+84
to
+86
| const locallyStorePublishableKey = await import('../../server/keyless-node.js') | ||
| .then(mod => mod.safeParseClerkFile()?.publishableKey) | ||
| .catch(() => undefined); |
There was a problem hiding this comment.
[minor] For readability
Suggested change
| const locallyStorePublishableKey = await import('../../server/keyless-node.js') | |
| .then(mod => mod.safeParseClerkFile()?.publishableKey) | |
| .catch(() => undefined); | |
| let locallyStorePublishableKey; | |
| try { | |
| const mod = await import('../../server/keyless-node.js'); | |
| locallyStorePublishableKey = mod.safeParseClerkFile()?.publishableKey; | |
| } catch { | |
| locallyStorePublishableKey = undefined; | |
| } |
There was a problem hiding this comment.
tbh i prefer the current one for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change