Skip to content

chore(e2e): Run keyless e2e tests in staging database #5078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Feb 4, 2025

Description

Keyless applications on e2e tests are never claimed and that hurts some of our metrics. This PR switches to the staging database for keyless applications, until we have a proper fix that all teams are happy with.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@panteliselef panteliselef requested a review from a team February 4, 2025 18:26
@panteliselef panteliselef self-assigned this Feb 4, 2025
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 971f439

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 6:28pm

@panteliselef panteliselef merged commit e4e75de into main Feb 4, 2025
32 checks passed
@panteliselef panteliselef deleted the elef/actls-84-use-staging-database-for-keyless-e2e-tests branch February 4, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants