feat(repo,testing): Apply testing tokens to E2E tests #5561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4b88762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmilewski
changed the title
tmilewski
force-pushed
the
tm/sdki-982-apply-testing-tokens-to-e2e-tests
branch
from
84e82d0 to
ef8eca4
Compare
tmilewski
changed the title
anagstef
approved these changes
Apr 9, 2025
| @@ -5,24 +5,29 @@ import dotenv from 'dotenv'; | |||
| import type { ClerkSetupOptions, ClerkSetupReturn } from './types'; | |||
|
|
|||
| export const fetchEnvVars = async (options?: ClerkSetupOptions): Promise<ClerkSetupReturn> => { | |||
| const { debug = false, dotenv: loadDotEnv = true, ...rest } = options || {}; | |||
There was a problem hiding this comment.
Nit: Why not destruct also publishableKey and secretKey here? 🤔
There was a problem hiding this comment.
@anagstef No specific reason. Makes sense, I'll update. Thanks!
There was a problem hiding this comment.
@anagstef Looking back at the code, it was cleaner to do it this way such that there weren't variable naming conflicts.
panteliselef
approved these changes
Apr 9, 2025
tmilewski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integration Tests:
This PR applies testing tokens to E2E tests via existing pathways.
It also creates
u.po.testingToken.setup()for tests which live outside existing helper-specific flows.@clerk/testing
I've added two additional options to
setupClerkto facilitate the functionality above:secretKey: Allow for explicitly passing the secret keydotenv: Enable automatic loading of dotenv files. Defaults totrueFixes SDKI-982
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change