Add codegen handling for infinity and NaN values. Make generic codege… #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n method a bit cleaner.
cnuernber
requested changes
May 20, 2021
| (and (number? vv) (neg? vv) (Double/isInfinite vv)) "##-Inf" | ||
| ;;Anything else should be derefed by name from Python | ||
| :else (format "(as-jvm/generic-pyobject (py-global-delay (py/get-attr @src-obj* \"%s\")))" k) | ||
| )] |
There was a problem hiding this comment.
What about long integers? Perhaps that first 'or' should also have (integer? vv).
There was a problem hiding this comment.
This check will handle longs:
;;Finite, non NAN numbers should be treated as literals
(and (number? vv) (Double/isFinite vv)) vv
Example:
(let [vv (long 1)]
(and (number? vv) (Double/isFinite vv)))
=> true
Or should we output longs as something other than their literal values?
There was a problem hiding this comment.
Oh perfect, I didn't realize Clojure would marshal the value in this case. OK, that is great.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n method a bit cleaner.