[inspect] Add inspect-show-analytics op #927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 5, 2025
| @@ -706,6 +706,24 @@ Returns:: | |||
|
|
|||
|
|
|||
|
|
|||
| === `inspect-show-analytics` | |||
There was a problem hiding this comment.
Before we merge this, please check whether we're using mostly "show" or "display" for this kind of terminology, so we're relatively consistent in the API.
There was a problem hiding this comment.
We do have display-namespaces in one place and that's it. Do you want this to say display too?
There was a problem hiding this comment.
Probably it would be slightly better. I like consistency. :-)
There was a problem hiding this comment.
Needs some changes to Orchard too. Alright, I'll do it.
alexander-yakushev
force-pushed
the
show-analytics
branch
3 times, most recently
from
9e4d679 to
f5c7344
Compare
alexander-yakushev
force-pushed
the
show-analytics
branch
from
f5c7344 to
5a3cc6c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR: clojure-emacs/orchard#329
Nothing very interesting going on here, just proxying.