Skip to content

Error in process filter: ClojureScript is not available when jack'ing in to shadow #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ikappaki opened this issue Dec 4, 2022 · 8 comments
Labels

Comments

@ikappaki
Copy link
Contributor

ikappaki commented Dec 4, 2022

Expected behavior

Able to jackin to shadow

Actual behavior

error in process filter: cider-verify-clojurescript-is-present: ClojureScript is not available.  See https://docs.cider.mx/cider/basics/clojurescript for details

Steps to reproduce the problem

  1. Install nodejs, and shadow-cljs with npm install shadow-cljs -g
  2. Create a an empty shadow-cljs.edn and a basic package.json in a new directory
    shadow-cljs.edn
{}

package.json

{"dependencies":
 {"shadow-cljs": "^2.20.13"}}
  1. Run npm install.
  2. Open shadow-cljs.edn in Emacs, and cider-jack-in-cljs, select shadow for ClojureScript REPL type and node-repl for the shadow-cljs build.
  3. The above error is returned.

Environment & Version information

CIDER version information

Include here the version string displayed when
CIDER's REPL is launched. Here's an example:

;; CIDER 1.6.0-snapshot (package: 1.6.0-snapshot), nREPL 1.0.0
;; Clojure 1.11.1, Java 17.0.5

Lein / Clojure CLI version

[email protected]

Emacs version

28.1

Operating system

MS-Windows

JDK distribution

Oracle

This is most likely due to #3272 cc @benjamin-asdf

@bbatsov bbatsov added the bug label Dec 5, 2022
@bbatsov
Copy link
Member

bbatsov commented Dec 5, 2022

In the mean time you can set cider-check-cljs-repl-requirements to nil as a workaround for this.

@bbatsov
Copy link
Member

bbatsov commented Dec 5, 2022

I'm also wondering if we should not kill this functionality at some point. It was mostly meant to prevent people from trying to run something without the necessary deps and provide them with more meaningful error messages, but a few years down the road I'm somewhat doubtful that this really added much value.

benjamin-asdf added a commit to benjamin-asdf/cider that referenced this issue Dec 5, 2022
@benjamin-asdf
Copy link
Contributor

benjamin-asdf commented Dec 5, 2022

@bbatsov Yea indeed. My suggested fix for now is to check both, demunge for nbb and (cider-library-present-p "cljs.core") for "normal".

@bbatsov
Copy link
Member

bbatsov commented Dec 5, 2022

@benjamin-asdf Your proposed fix seems reasonable to me.

@bbatsov
Copy link
Member

bbatsov commented Dec 5, 2022

@benjamin-asdf Are you going to submit this as a PR?

@pieterbreed
Copy link

For what it's worth; the suggested work-around does not work for me.

@bbatsov bbatsov closed this as completed in b119912 Dec 6, 2022
@benjamin-asdf
Copy link
Contributor

@pieterbreed you can check with this version. I am pretty sure that is a fix.

@pieterbreed
Copy link

@benjamin-asdf indeed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants