GitHub Workflows security hardening #3284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <[email protected]>
|
Thanks! |
iarenaza
added a commit
to iarenaza/moodle-filter_multilang2
that referenced
this pull request
Aug 16, 2023
Copied from clojure-emacs/cider#3284 This commit adds explicit permissions section[1] to workflows. This is a security best practice because by default workflows run with extended set of permissions[2] (except from on: pull_request from external forks[3]). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection[4] or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level[5] and grant write permissions on job level[6] case by case. [1] https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions [2] https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token [3] https://securitylab.github.com/research/github-actions-preventing-pwn-requests/ [4] https://securitylab.github.com/research/github-actions-untrusted-input/ [5] https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions [6] https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test)eldev lint) which is based onelisp-lintand includescheckdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.Thanks!
If you're just starting out to hack on CIDER you might find this section of its
manual extremely useful.