Skip to content

cljr-slash magic require js/ behavior is determined by file type, not language context #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgtized opened this issue Jul 11, 2022 · 2 comments · Fixed by #546
Closed

Comments

@dgtized
Copy link
Contributor

dgtized commented Jul 11, 2022

Context: #522 (comment)

Specifically this is discussing the behavior of cljr--js-alias-p, which ignores a magic require alias prefix "js" if and only if it's in a cljs file. It will attempt to lookup the namespace in a cljc file. It's less clear what the behavior is inside of a #?(:clj) or #?(:cljs) language context within a cljc file, but I would expect that it should use the cljs behavior inside of a cljs context in a cljc file.

Expected behavior is that js/ in a cljs context should ignore the magic alias lookup for both cljs and cljc files.

@vemv
Copy link
Member

vemv commented Jul 26, 2023

Hey @dgtized , would you be interested in tackling this one?

Probably at this point we already have the primitives for making it easy.

@dgtized
Copy link
Contributor Author

dgtized commented Jul 26, 2023

I can take a look, I agree it should be pretty easy at this point. That said, I'm pretty low capacity for the next month or two, so no promises on when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants