[Fix #302] Make ad work with prismatic/schema
#324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it seems to me that you submitted this commit in #325 too... I guess that was not the intention?! (see my comments on the code there) |
|
Actually was intended, as they touched the same code and I tried to reduce the amount of time spent dealing with merge conflicts. |
|
I am a bit confused then. Where do you want to track this commit? in this PR or in #325? |
|
Here, I'll rebase etc if you want changes to this commit |
|
strangely I can't find that comment of mine. I was only pointing out that perhaps worth mentioning in the changelog that this understands all prefixed |
expez
force-pushed
the
ad-and-schemas
branch
2 times, most recently
from
97c838d to
435b125
Compare
|
nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.