Pass :always-return-ns-form true to clean-ns

[DerGuteMoritz]

This allows for cleaning up whitespace even if there are no structural changes.

Note that I went with always replacing the ns form even if there were no whitespace changes because there's no function for only extracting the current ns form for comparison (in other words: there's only clojure-delete-and-extract-sexp but no clojure-extract-sexp). It's probably fine!

Depends on clojure-emacs/refactor-nrepl#407 and a corresponding update of cljr-injected-middleware-version once released.

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• The new code is not generating byte compile warnings (run cask exec emacs -batch -Q -L . -eval "(progn (setq byte-compile-error-on-warn t) (batch-byte-compile))" clj-refactor.el)
• All tests are passing (run ./run-tests.sh)
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)

[vemv]

Thanks again!

Note that I went with always replacing the ns form even if there were no whitespace changes because there's no function for only extracting the current ns form for comparison

Unfortunately this doesn't seem ideal as it can needlessly touch the underlying file - might be wasteful for misc other tools.

Note that there's defun cljr--maybe-eval-ns-form. Jumping to definition from there you can find inspiration.

Cheers - V

[vemv]

Please expand on this so that ppl can see its usefulness

[DerGuteMoritz]

How about now?

[DerGuteMoritz]

Unfortunately this doesn't seem ideal as it can needlessly touch the underlying file - might be wasteful for misc other tools.

Ah yes, point taken!

Note that there's defun cljr--maybe-eval-ns-form. Jumping to definition from there you can find inspiration.

Took clojure-delete-and-extract-sexp as inspiration instead. Not too happy about the string-trim-right which is necessary because the string returned by refactor-nrepl comes with a trailing newline. Could of course also be changed on that end but oh well!

[vemv]

Very nice!

LGTM.

Let me release refactor-nrepl first so that merging this will work.

[vemv]

I've released https://clojars.org/refactor-nrepl/versions/3.10.0

Please cherry-pick this commit 282a43c and test out the changes for about a week!

Cheers - V

[DerGuteMoritz]

Works as intended so far 👍

[vemv]

Thanks much!

I've cut 3.12.0, to be melpa-visible in a bit.