Incorrect indentation / fontification after metadata forms

[yuhan0]

Expected:

Metadata forms ^:foo / ^{:foo 123} should not affect indentation of the following forms

[a b [c ^:foo
      d
      e]]

Actual:

;; with clojure-ts-indent-style = 'semantic
[a b [c ^:foo
        d
      e]]

;; with clojure-ts-indent-style = 'fixed
[a b [c ^:foo
d
      e]]

---

Some font-locking of the following form also appears to be affected:

---

Typing a closing delimiter with Paredit (paredit-close-curly) can also cause the point to jump to the wrong position:

;;   ↓with point here, type "}"
[a ^{ } (b) c]
;;     |   |     
;;     |   actual
;;     expected

[bbatsov]

Likely the metadata is not considered in the existing TS queries. I'll take a look when I can.

[yuhan0]

(The Paredit navigation issue is probably related to #62, and not directly to this)

[rrudakov]

Some font-locking of the following form also appears to be affected:

This should be fixed by #66

[rrudakov]

Regarding indentation, I can fix that, but I'm not sure if it will be correct. The value with metadata is a single node, it looks like this in the syntax tree:

(sym_lit
    meta: 
     (meta_lit marker: ^
      value: (kwd_lit marker: : name: (kwd_name)))
    name: (sym_name))

And it seems logical to me that metadata and value are aligned vertically (there is a rule defined in the code specifically for that).

(def x
  [a b [c ^:foo
          d
        e]])

Are there any guidelines about this indentation?

[yuhan0]

That might be more logical, but other formatters like cljfmt / zprint / standard-clojure-style don't behave this way, so it's probably better to follow the status quo. This situation turns out to be fairly common once you consider type hints and metadata on def / defonce / ns symbols:
https://github.com/clojure/clojure/blob/fb22fd778a272b034684a4ee94509552b46ee8a9/src/clj/clojure/core.clj#L5892
https://github.com/clojure/clojure/blob/fb22fd778a272b034684a4ee94509552b46ee8a9/src/clj/clojure/string.clj#L324

[rrudakov]

Thanks for the examples @yuhan0. I've also found some issues with syntax highlighting related to metadata presence. I'll create a PR with all fixes soon.