Inline treesit-query-p to ensure compatibility with Emacs 30
#102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
May 29, 2025
clojure-ts-mode.el
Outdated
| @@ -2479,7 +2479,9 @@ This function checks if `clojure-ts-mode' is compatible with the | |||
| currently installed grammar. The simplest way to do this is to validate | |||
| a query that is valid in a previous grammar version but invalid in the | |||
| required version." | |||
| (treesit-query-valid-p 'clojure '((sym_lit (meta_lit))))) | |||
| (ignore-errors | |||
There was a problem hiding this comment.
This doesn't look like inlining to me. :D
There was a problem hiding this comment.
Would you prefer to define a separate function?
I just replaced the treesit-query-valid-p call with it's implementation.
There was a problem hiding this comment.
Ah, I didn't realize at first that the implementation was so simple. Still, I prefer a separate function so it'd be more likely we remember to replace it with treesit-query-valid-p when the time comes.
rrudakov
force-pushed
the
fix/missing-treesit-function
branch
from
74de948 to
b9b03d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #99 (comment)