Skip to content

Introduce clojure-ts-extra-def-forms customization #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025

Conversation

rrudakov
Copy link
Contributor

Partially (or fully?) addresses #15

In this PR I only added clojure-ts-extra-def-forms variable. I think we can add low-level customization if there is a request for that. For now dynamic font-lock from CIDER and this variable should cover most of the users needs.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

rrudakov added 2 commits May 30, 2025 22:01
- Remove 'append' from clojure-ts--align-query and extend it to match :let
vector in 'for' and 'doseq' forms.
- Remove hack with setting ':override t' for embedded parsers; it was added
before I figured out how to not fontify some strings.
@bbatsov bbatsov merged commit 82c4b33 into clojure-emacs:main May 31, 2025
3 checks passed
@bbatsov
Copy link
Member

bbatsov commented May 31, 2025

I agree that's more than enough at this point. Great work!

@rrudakov rrudakov deleted the feature/15-extra-def-font-lock branch May 31, 2025 06:34
rrudakov added a commit to rrudakov/clojure-ts-mode that referenced this pull request Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants