Skip to content

Introduce clojure-ts-completion-at-point-function #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

rrudakov
Copy link
Contributor

@rrudakov rrudakov commented Jun 3, 2025

Close #107


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakov
Copy link
Contributor Author

rrudakov commented Jun 3, 2025

Note: I didn't implement support of letfn and :let bindings for for and doseq. Probably will do it in a separate PR.

@bbatsov bbatsov merged commit 95aed26 into clojure-emacs:main Jun 3, 2025
3 checks passed
@bbatsov
Copy link
Member

bbatsov commented Jun 3, 2025

Fantastic work! 👏 👏 👏

@rrudakov
Copy link
Contributor Author

rrudakov commented Jun 3, 2025

That was fast :) Thanks!

@rrudakov rrudakov deleted the feature/107-completion branch June 3, 2025 20:49
@bbatsov
Copy link
Member

bbatsov commented Jun 3, 2025

And it will make the 0.5 release I was planning to cut tomorrow morning. :-)

@rrudakov
Copy link
Contributor Author

rrudakov commented Jun 3, 2025

And it will make the 0.5 release I was planning to cut tomorrow morning. :-)

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree-sitter powered completion
2 participants