Skip to content

Fix performance issue by pre-compiling Tree-sitter queries #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

rrudakov
Copy link
Contributor

@rrudakov rrudakov commented Jun 5, 2025

There is one trade-off: Markdown syntax won't be highlighted in docstrings of custom extra def forms. I think it could be solved, but it would make the code more complicated.

Close #109


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

@rrudakov rrudakov force-pushed the fix/109-performance-issue branch from 6a80d91 to 1c2b25f Compare June 5, 2025 17:00
@bbatsov
Copy link
Member

bbatsov commented Jun 5, 2025

You should probably document the trade-off/caveat in the README.

…r queries

There is one trade-off: Markdown syntax won't be highlighted in docstrings of
custom extra def forms.  I think it could be solved, but it would make the code
more complicated.
@rrudakov rrudakov force-pushed the fix/109-performance-issue branch from 1c2b25f to a2351c1 Compare June 5, 2025 19:41
@rrudakov
Copy link
Contributor Author

rrudakov commented Jun 5, 2025

You should probably document the trade-off/caveat in the README.

Done.

@bbatsov bbatsov merged commit 569ed6c into clojure-emacs:main Jun 5, 2025
3 checks passed
@rrudakov rrudakov deleted the fix/109-performance-issue branch June 5, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange freeze when finding a clojure/clojurescript file (seems to be inside treesit-query-compile)
2 participants