analyzer: introduce a :compile-like key
#14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vemv
commented
Sep 29, 2023
| m {:class (name (:type cause-data)) | ||
| :phase (-> cause-data :data :clojure.error/phase) | ||
| :phase phase |
There was a problem hiding this comment.
At first I was tempted to put a synthetic value under :phase, but that might be surprising to anyone using Haystack as a lib.
I plan to do some transparent changes in cider.el such that we can we can change this default:
(defcustom cider-clojure-compilation-error-phases '("read-source"
"macro-syntax-check"
"macroexpansion"
"compile-syntax-check"
"compilation"
+ "cider/compile-like"
bbatsov
reviewed
Sep 29, 2023
| @@ -338,14 +338,25 @@ | |||
| (flag-duplicates) | |||
| (flag-tooling))))) | |||
|
|
|||
| (defn- compile-like-exception? | |||
There was a problem hiding this comment.
I think you should add some of your explanations from the PR here, so it's clear why we need this.
Not sure I like the term, but I can't propose a better one and the PR looks good overall. |
bbatsov
reviewed
Sep 29, 2023
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## master (unreleased) | |||
|
|
|||
| * `analyzer`: include a `:compile-like` key which indicates if the error happened at a "compile-like" phase. | |||
| * It represents exceptions that happen at runtime (and therefore never include a `:phase`) which however, represent code that cannot possibly work, and therefore are a 'compile-like' exception (i.e. a linter could have caught them). | |||
There was a problem hiding this comment.
You used the double quotes above and single here and below. This triggers my OCD. :D
|
Amended with feedback - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In CIDER, when I type
(.foo "")at the repl, no stacktrace should be displayed, because it adds nothing to the message that already will be displayed.However, this is a runtime exception, not a compile-one, so we can't use our new
:phaselogic.I asked about that here: https://ask.clojure.org/index.php/13339/tools-better-detect-errors-coming-existing-methods-fields
Changes
Introduce a
:compile-likekey indicating if we deem the exception "compile-like".We can expand the meaning of it as we find more, similar cases.
Cheers - V