Skip to content

Change default to no prefix re-writing #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Conversation

expez
Copy link
Member

@expez expez commented Jun 27, 2021

The default has already been changed in clj-refactor so this is
essentially a no-op, but makes the change more explicit for those
working on the middleware.

@expez expez force-pushed the no-more-prefix-rewriting branch from ade2282 to 1be6ddd Compare June 27, 2021 21:37
@bbatsov
Copy link
Member

bbatsov commented Jun 28, 2021

There's a linting failure.

@expez expez force-pushed the no-more-prefix-rewriting branch from 1be6ddd to d03206e Compare June 28, 2021 07:53
The default has already been changed in clj-refactor so this is
essentially a no-op, but makes the change more explicit for those
working on the middleware.
@expez expez force-pushed the no-more-prefix-rewriting branch from d03206e to 18f740a Compare June 28, 2021 08:12
@expez
Copy link
Member Author

expez commented Jun 28, 2021

There's a linting failure.

Fixed, hopefully. My emacs settings are really working against me with this linter 😢

Copy link
Member

@vemv vemv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bbatsov
Copy link
Member

bbatsov commented Jun 28, 2021

@expez You can simply update cljfmt's settings if something's off. That's what I do for the other projects - e.g. https://github.com/clojure-emacs/cider-nrepl/blob/master/project.clj#L133

@bbatsov
Copy link
Member

bbatsov commented Jun 28, 2021

I'll push a new snapshot now.

@bbatsov bbatsov merged commit 2295c2c into master Jun 28, 2021
@expez expez deleted the no-more-prefix-rewriting branch June 28, 2021 11:41
vemv added a commit that referenced this pull request Nov 5, 2021
Makes it more consistent with the no-prefix preference #308
bbatsov pushed a commit that referenced this pull request Nov 5, 2021
Makes it more consistent with the no-prefix preference #308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants