Add system-info instance callback #200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow runners to update their own system information. Runners can now send back os_name, os_version and agent_id back as part of a POST to CALLBACK_URL/system-info/. The goal is to get better info in regard to the actual OS that's running and to move the agent_id from the status updates to the system-info callback. The status updates should be used only to send back info about the status of the installation process. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
added a commit
to gabriel-samfira/garm-provider-common
that referenced
this pull request
Jan 4, 2024
With cloudbase/garm#200 userdata is now able to update the system information of a runner. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
gabriel-samfira
added a commit
to gabriel-samfira/garm-provider-k8s
that referenced
this pull request
Jan 13, 2024
A new callback is available in garm which allows runners to send info about themselves from userdata. This new callback allows instances to report their os_name, os_version and the GH agent_id. See cloudbase/garm#200 This change allso makes sure that curl is installed in the image, otherwise the userdata will never work. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
rafalgalaw
pushed a commit
to mercedes-benz/garm-provider-k8s
that referenced
this pull request
Jan 17, 2024
A new callback is available in garm which allows runners to send info about themselves while installing. This new callback allows instances to report their os_name, os_version and the GH agent_id. See cloudbase/garm#200 This change also makes sure that curl is installed in the image, otherwise the entrypoint will fail. Signed-off-by: Gabriel Adrian Samfira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow runners to update their own system information. The goal is to get better info about the runners that we spawn. Right now we just retrieve os_name, os_version and agent_id, but this can be expanded later to include other info.
We also want to collect the actual agent_id of the GH runner using a callback that makes more sense. The status updates should only report installation status, which is informational.