Add option to show a back button to Navigation and View components #51
Conversation
| @@ -12,9 +12,11 @@ | |||
| class="c-view__navigation" | |||
| :assistive-title="assistiveTitle" | |||
| :current-tab="activeTab" | |||
| :show-back-button="showBackButton ? '' : null" | |||
There was a problem hiding this comment.
Figuring this out took me like 2 hours. Turns out that boolean properties that are passed down need to be properly casted as boolean arguments (like the disabled HTML argument), otherwise they are casted to a string and everything breaks 🥲.
See vuejs/docs#1972 (comment) and the related playground for more info.
|
| @@ -1,5 +1,16 @@ | |||
| <template> | |||
| <div class="navigation-bar"> | |||
| <button | |||
There was a problem hiding this comment.
Wouldn't it make sense to use our toolkit button here? or it's better to use just the default one?
There was a problem hiding this comment.
I went for the HTML button for ease of use, since it is easier to style. Would be trickier to do so with the toolkit button.
There was a problem hiding this comment.
May be good to consider some way for the future to make the toolkit button usable in those cases, or just drop it for the HTML one 😜
paulinaczybir
deleted the
feat/add-back-button-to-navigation-component
branch
Added the option to show a back button in the Navigation (& View) component:
