(fix) Fix mtar cleanup for acceptance tests #3691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalan316
reviewed
Apr 7, 2025
joergdw
requested changes
Apr 7, 2025
Co-authored-by: joergdw <[email protected]>
|
joergdw
approved these changes
Apr 7, 2025
asalan316
added
deploy-to-cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When undeployment fails during the acceptance test teardown phase—specifically in the
autoscaler-cleanupstep—it can leave behind orphaned (zombie) orgs and spaces. These residual resources can clutter the environment and cause issues for subsequent test runs.Example
In this workflow run, the cleanup process did not successfully remove all resources.
This occurred in PR #3629, where the test org and space were not cleaned up as expected.
Fix / Improvement
Now
cf undeployfails gracefully