Potential fix for code scanning alert no. 422: Clear-text logging of sensitive information #3715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/cloudfoundry/app-autoscaler-release/security/code-scanning/422
To fix the issue, we need to ensure that sensitive information, such as the
Password
field, is not logged in clear text. The best approach is to exclude thePassword
field from the log entirely or replace it with a placeholder (e.g.,"***"
). This ensures that sensitive data is not exposed in the logs while still allowing other non-sensitive information to be logged for debugging purposes.Specifically:
src/autoscaler/db/sqldb/storedprocedure_sqldb.go
to exclude thePassword
field from thecreds
object.creds
object that omits or masks thePassword
field before passing it to the logger.Suggested fixes powered by Copilot Autofix. Review carefully before merging.