Skip to content

Add HTTP/2 configuration to Staticfile docs #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

Gerg
Copy link
Member

@Gerg Gerg commented Oct 8, 2021

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

@robdimsdale
Copy link
Member

Hey, this looks good in principle. I haven't actually run it through the docs generator to see if it renders properly.

Separately, I want to wait for the buildpack to be released before merging the docs so they don't end up going public too soon.

@robdimsdale
Copy link
Member

cc @menehune23

@mjgutermuth mjgutermuth merged commit cde485a into cloudfoundry:master Nov 3, 2021
@mjgutermuth
Copy link
Contributor

mjgutermuth commented Nov 3, 2021

Thanks @Gerg! I just saw your note above @robdimsdale --is this ready to merge? If not, I can revert. Thanks!

@menehune23
Copy link
Contributor

@mjgutermuth My understanding is that it was safe to merge. Correct me if I'm wrong @robdimsdale

@robdimsdale
Copy link
Member

Should be fine. I was waiting until we shipped the buildpack before merging the notes so they didn't describe a feature that hadn't shipped yet. We shipped the buildpack so the notes are good to go. Thanks for checking @mjgutermuth !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants