Skip to content

prevent IPIP tunnel creation when --override-nexthop=true #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

murali-reddy
Copy link
Member

@murali-reddy murali-reddy commented Aug 15, 2018

When --override-nexthop=ture next hop that will be advertised depends on the local IP used and the peer. So it does not necessarily be node IP. Hence the check

if !nrc.nodeSubnet.Contains(nexthop) && !nrc.overrideNextHop {
    if !nrc.enableOverlays {

@roffe roffe changed the title prevent IPIP tunnel creation when --override-nexthop=ture prevent IPIP tunnel creation when --override-nexthop=true Aug 15, 2018
@murali-reddy
Copy link
Member Author

Merging based on testing. There is no change to default behaviour i.e) create IPIP tunnels when nodes are in different subnets and overlay is enabled.

Only in case of --override-nexthop=true tunnels wont be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant