feat: Add Plugin V3 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
approved these changes
Jun 16, 2023
plugin/v3/plugin.proto
Outdated
Comment on lines
25
to
44
| enum REGISTRY { | ||
| REGISTRY_GITHUB = 0; | ||
| REGISTRY_GRPC = 1; | ||
| REGISTRY_LOCAL = 2; | ||
| } | ||
|
|
||
| enum SCHEDULER { | ||
| SCHEDULER_DFS = 0; | ||
| SCHEDULER_ROUND_ROBIN = 1; | ||
| } | ||
|
|
||
| enum Operator { | ||
| EQUAL = 0; | ||
| LESS_THAN = 1; | ||
| } | ||
|
|
||
| enum PK_MODE { | ||
| DEFAULT = 0; | ||
| CQ_ID_ONLY = 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| enum REGISTRY { | |
| REGISTRY_GITHUB = 0; | |
| REGISTRY_GRPC = 1; | |
| REGISTRY_LOCAL = 2; | |
| } | |
| enum SCHEDULER { | |
| SCHEDULER_DFS = 0; | |
| SCHEDULER_ROUND_ROBIN = 1; | |
| } | |
| enum Operator { | |
| EQUAL = 0; | |
| LESS_THAN = 1; | |
| } | |
| enum PK_MODE { | |
| DEFAULT = 0; | |
| CQ_ID_ONLY = 1; | |
| } | |
| enum Registry { | |
| REGISTRY_UNSPECIFIED = 0; | |
| REGISTRY_GITHUB = 1; | |
| REGISTRY_GRPC = 2; | |
| REGISTRY_LOCAL = 3; | |
| } | |
| enum Scheduler { | |
| SCHEDULER_UNSPECIFIED = 0; | |
| SCHEDULER_DFS = 1; | |
| SCHEDULER_ROUND_ROBIN = 2; | |
| } | |
| enum PKMode { | |
| PK_MODE_UNSPECIFIED = 0; | |
| PK_MODE_DEFAULT = 0; | |
| PK_MODE_CQ_ID_ONLY = 1; | |
| } |
There was a problem hiding this comment.
Couple of suggestions:
- Use Pascal case for enum names (follows the style guide: https://protobuf.dev/programming-guides/style/#enums)
- Add an "_UNSPECIFIED" as the first entry in each case so it's possible to distinguish unset values
- Removes unused enums
| message Write { | ||
| message Request { | ||
| oneof message { | ||
| WriteOptions options = 1; |
There was a problem hiding this comment.
Should options not be outside of the oneof?
plugin/v3/plugin.proto
Outdated
Comment on lines
72
to
80
| message WriteOptions { | ||
| bool migrate_force = 1; | ||
| } | ||
|
|
||
| message MessageMigrateTable { | ||
| // marshalled arrow.Schema | ||
| bytes table = 1; | ||
| bool migrate_force = 2; | ||
| } |
There was a problem hiding this comment.
We now have migrate_force in two places: which one should be preferred?
There was a problem hiding this comment.
removed this one.
hermanschaaf
approved these changes
Jun 23, 2023
kodiakhq bot
pushed a commit
to cloudquery/plugin-pb-go
that referenced
this pull request
Jun 23, 2023
Instead of #15. Plugin V3 Protocol client/server regenerated from cloudquery/plugin-pb#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.