Skip to content

Don't always scroll to the top #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
extesy opened this issue Mar 18, 2013 · 4 comments
Closed

Don't always scroll to the top #2

extesy opened this issue Mar 18, 2013 · 4 comments

Comments

@extesy
Copy link

extesy commented Mar 18, 2013

When the intro'ed control is already entirely visible on the screen, there's no need to scroll it to the very top. Otherwise on the vertically oriented (or just big enough) screens it becomes very inconvenient to read.
@clu3
Copy link
Owner

clu3 commented Mar 21, 2013

@extesy that's true I agree. I'll handle this when I have some more free time. Cheers

@jcorreia
Copy link

Hi, I have this same problem.
Im using bootstrap with a nav bar and as it scrolls to the top, part of the popover title hides behind the navbar.

Thanks

clu3 pushed a commit that referenced this issue May 27, 2013
1. fixed issue #2: Dont always scroll to top, if the element is entir…
20a9c19 
…ely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
@clu3
Copy link
Owner

clu3 commented May 27, 2013

@extesy @jcorreia I've fixed the problem with the above commit,cheers

@clu3 clu3 mentioned this issue May 27, 2013
Open
@clu3 clu3 closed this as completed Jun 3, 2013
tsrivishnu pushed a commit to tsrivishnu/bootstro.js that referenced this issue Sep 28, 2013
@tsrivishnu
1. fixed issue clu3#2: Dont always scroll to top, if the element is e…
92c35b9 
…ntirely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
tsrivishnu pushed a commit to tsrivishnu/bootstro.js that referenced this issue Sep 28, 2013
@tsrivishnu
1. fixed issue clu3#2: Dont always scroll to top, if the element is e…
e560808 
…ntirely visible, do not scroll to top.\n 2. show data can be gotten from ajax to keep HTML clean \n 3. added a few more options: nextButtonText for a simpler nextButton,prevButtonText,finishButtonText. Those attributes can also be overridded by a specific element's corresponding attribute such as data-bootstro-nextButtonText.\n 4. Added a few function handlers in option: onComplete,onExit.\n 5. options.margin added to keep element nicely visible within a some top margin
@elegantnodejs
Copy link

good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@extesy @clu3 @jcorreia @elegantnodejs