Patch smoothing utility to handle short signals (for backfill) #437
Conversation
|
Should probably be merged before @chinandrew's refactors go live, so that backfill is handled properly. |
* mostly documentation fixes, confrm to pydocstyle * add missing documentation for the argument boundary_method * remove the len(signal) < window_length constraint; forgot I wrote the boundary methods to handle these cases
dshemetov
force-pushed
the
dev-smoothing_patch
branch
from
b0607ef to
4d6f65e
Compare
|
Cool. You know, I'm running into issues where JHU tests are giving the smoother an array full of NANs. That makes me want to change the nan handling to be a bit more permissive (a full array of nans should pass through, an array left-padded with nans should start imputing only once the first value is seen, etc.), so I think I'll handle that in this PR too. |
If it's independent of this change, I'd recommend making it another PR just to keep things clean. |
|
Noted. I'll do that. |
Mostly documentation fixes, confrm to pydocstyle, add missing documentation for the argument boundary_method.
But also I removed the len(signal) < window_length constraint I added at the last minute; I forgot I wrote boundary methods to handle that case a few months ago.