-
Notifications
You must be signed in to change notification settings - Fork 68
flusurv acquisition is broken #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
acquisition
changes acquisition logic
bug
data quality
Engineering
Used to filter issues when synching with Asana
Comments
dfarrow0
added a commit
to dfarrow0/delphi-epidata
that referenced
this issue
Oct 9, 2020
- temporary fix for cmu-delphi#242 - should revisit once new age groups are defined unit: ✔ All 49 tests passed! 53% (594/1114) coverage. integration: ✔ All 24 tests passed!
webapp still not updated, new age groups still undefined. will check back in another week. |
4 tasks
Age groups 10, 11, and 12 are now defined, along with additional age, sex, and race groups, as:
|
Additionally, new strata are available back to ~2009 at least for some locations. We should consider backfilling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
acquisition
changes acquisition logic
bug
data quality
Engineering
Used to filter issues when synching with Asana
The flusurv data acquisition steps have begun failing with the following stack trace:
Tip: reproduce locally by following the dev guide (i.e. bringing up database and web servers) and then running:
docker run --rm --network delphi-net delphi_python python3 -m delphi.epidata.acquisition.flusurv.flusurv_update CA
The cause appears to be that the data now, as of 2020w40 (start of the 2020 flu season), includes 3 new age groups. This is great news in general. However, the definition of the new groups is unknown as CDC's webapp doesn't appear to have been updated yet.
Once the site above is updated with definitions of the new age groups, we should capture them. This will require fairly straightforward updates to the acquisition script, the database table, the API server, and the API docs.
In the meantime, as a stop-gap, I'll submit a fix which simply ignores the new, unknown, age groups.
TODO: revisit a week from today -- 2020-09-16
The text was updated successfully, but these errors were encountered: