-
Notifications
You must be signed in to change notification settings - Fork 68
Decouple client release from Delphi release #1465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/workflows/create-release.yml
Outdated
run: echo "sha=$(git rev-parse origin/main)" >> $GITHUB_OUTPUT | ||
- name: Get Python client file changes | ||
id: changed-py | ||
uses: tj-actions/changed-files@v44 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we use dorny/paths-filter
here (and also in release-helper.yml
) to match the usage in the covidcast-indicators
repo? fewer dependencies and reinvented wheels make for easier support and maintenance.
https://github.com/cmu-delphi/covidcast-indicators/blob/a6ea00355d79a47cc09db8090f6e5121c718de0f/.github/workflows/create-release.yml#L32-L40
https://github.com/cmu-delphi/covidcast-indicators/blob/a6ea00355d79a47cc09db8090f6e5121c718de0f/.github/workflows/publish-release.yml#L31-L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can give it a go, it should support the same features as changed-files
.
Pushed a merge from dev and resolved conflicts with #1470. |
* add comments * revert bumpversion configs Co-authored-by: george <[email protected]>
fix(pyclient ci): validate version arg in create-release
@melange396 @dshemetov this is ready once again! Here's an updated rundown of my CI tests as well. For testing purposes, I've forked the I then ran several mock releases within the same repository: 4.1.24
4.1.25
4.1.26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I looked over your fork and its associated PRs. The overall behavior looks to be consistent with what you describe and what you and George agreed on in #1296 (namely, Python client stays loosely coupled - it doesn't update if there are no changes to delphi_epidata.py
or contents of .../packaging/pypi/
, but then "catches up" to the main repo version when there is a change). No further notes from me.
|
@melange396 @dshemetov I've updated the PR again! Also reran the tests and updated the links here: #1465 (comment) |
It looks like you tested this with just "patch" as the argument to "Create Release"... Did you try with "major" (or "minor") and an explicit version to make sure those do the right thing too? |
@melange396 I ran some tests for these just now and everything's looking OK:
|
Closes #1296.
Summary:
Semi-detaches the versioning of the Python client and delphi-epidata.
This means that a new version of the Python client is only released when changes are made to the client file - when this is the case, however, it is synced to the current delphi-epidata version.
For further details, see #1296 (comment).
Prerequisites:
dev
branchdev