Skip to content

Hotfix for nhsn doc #1581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Hotfix for nhsn doc #1581

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f2d431
new title for NHSN page
nmdefries Jan 24, 2025
7898ff4
made more fixes
aysim319 Jan 27, 2025
38adacf
Merge branch 'dev' into ndefries/nhsn-title
melange396 Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/api/covidcast-signals/nhsn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parent: Data Sources and Signals
grand_parent: Main Endpoint (COVIDcast)
nav_order: 1
---
# National Healthcare Safety Network Respiratory Hospitalizations
# National Healthcare Safety Network Respiratory Hospitalizations (Continuation of [HHS]((see [date format docs](../hhs.md)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont know if i would put this here. first, its a little weird to have a link in the title heading. second, it could be misleading because the document uses "HHS" in a different context (for geographic regions), and this would be better mentioned with a little more detail in the "Overview" and/or "Limitations" sections. neither is "wrong"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ticket mentioned that we should say more prominently that this data source is the continuation of the old HHS source. @carlynvandyke thoughts? maybe put it in the overview?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think George's comment makes sense. I'm going to draft some language to put in the overview.

{: .no_toc}

* **Source name:** `nhsn`
Expand Down
Loading