-
Notifications
You must be signed in to change notification settings - Fork 68
Signal Documentation Coverage Endpoint #1584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Proposed SQL for this endpoint
|
Sonar is failing on a security flaw around using HTTP instead of HTTPS, but it is for a test. This is how it's done in other tests too. |
…ta into sig_doc_coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is good stuff, its nice and tight! i wouldnt have even thought about going with QueryBuilder and a db VIEW, but together they work well in getting the job done.
ive got a number of smallish suggestions that you can hopefully just hit "accept" for, a couple that you can ignore if you want, and a couple for removing duplicate results. for a bigger change, you should at least one more test case (which shouldnt be that complicated if you use CovidcastTestRow
).
integrations/acquisition/covidcast/test_coverage_crossref_update.py
Outdated
Show resolved
Hide resolved
integrations/acquisition/covidcast/test_coverage_crossref_update.py
Outdated
Show resolved
Hide resolved
integrations/acquisition/covidcast/test_coverage_crossref_update.py
Outdated
Show resolved
Hide resolved
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
…te.py Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
…te.py Co-authored-by: george <[email protected]>
…ta into sig_doc_coverage
integrations/acquisition/covidcast/test_coverage_crossref_update.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few things more to clean up the script runner, i dont know why i didnt mark them before
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
Co-authored-by: george <[email protected]>
…te.py Co-authored-by: george <[email protected]>
…ta into sig_doc_coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome! nice work!
addresses issue(s) #1583
Summary:
Create a new endpoint that returns a list of signals when given a geo. There were other endpoints that did this in the past, but the tables they read from are no longer around in epi v4. Starting from scratch will be much quicker and rely less on legacy code.
Once this is merged, I will also make issues to delete the old coverage code so that we don't have duplicate endpoints.
Prerequisites:
dev
branchdev