Skip to content

updating gh 'actions/cache' away from deprecated v2 #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

melange396
Copy link
Collaborator

@melange396 melange396 commented Feb 25, 2025

actions/cache@v2 is now deprecated, this sets it to v4 in all of the references to it in this repo.

this is the gh actions failure that prompted this change: https://github.com/cmu-delphi/delphi-epidata/actions/runs/13397502938/job/37420098843

here is a subsequent successful run of it (run from this branch) : https://github.com/cmu-delphi/delphi-epidata/actions/runs/13530875353/job/37812545923
and the PR it produced: #1605

@melange396 melange396 force-pushed the update_ghactions_cache branch from 83438a3 to 685976b Compare February 25, 2025 20:57
@melange396
Copy link
Collaborator Author

whoops! i force-pushed because this PR branch was not based on the current dev branch, but instead on an older one which did not include #1548. in a moment, i will re-run the csv sync gh action and update the links in the first comment of this PR with new references.

Copy link
Contributor

@korlaxxalrok korlaxxalrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 :shipit:

@melange396
Copy link
Collaborator Author

whoops again! #1605 was merged into this branch instead of the dev branch because i ran the sync workflow from here (and i forgot to change it in the other PR). i think we should be able to remedy this (and keep the commit history sane) by doing a "rebase merge" on this PR...

@melange396 melange396 merged commit 0816d13 into dev Feb 25, 2025
8 checks passed
@melange396 melange396 deleted the update_ghactions_cache branch February 25, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants